server: remove username required condition for listVmsForImport by shwstppr · Pull Request #9124 · apache/cloudstack

shwstppr · 2024-05-24T12:06:13Z

Description

Fixes #8414

Doc changes added apache/cloudstack-documentation#401

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#8414 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

codecov · 2024-05-24T12:15:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.95%. Comparing base (1577218) to head (e2fb453).
Report is 22 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9124      +/-   ##
============================================
- Coverage     14.96%   14.95%   -0.01%     
- Complexity    11002    11008       +6     
============================================
  Files          5373     5378       +5     
  Lines        469315   469804     +489     
  Branches      59847    58391    -1456     
============================================
+ Hits          70233    70276      +43     
- Misses       391309   391745     +436     
- Partials       7773     7783      +10

Flag	Coverage Δ
uitests	`4.29% <ø> (-0.01%)`	⬇️
unittests	`15.66% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shwstppr · 2024-05-24T13:04:25Z

@blueorangutan package

blueorangutan · 2024-05-24T13:06:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-24T14:12:19Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9701

weizhouapache

code lgtm

DaanHoogland

clgtm

vishesh92

clgtm. didn't test.

DaanHoogland · 2024-05-28T08:55:28Z

@shwstppr as the parameters are not used, should these also be removed from the Cmd class?

weizhouapache · 2024-05-28T09:28:07Z

@shwstppr as the parameters are not used, should these also be removed from the Cmd class?

currently vms are listed by virsh command (endpoint is the remote server)
However, it does not work in some cases (e.g. libvirt uses ssl).
username/password could be useful in the future

vishesh92 · 2024-05-28T09:31:19Z

@shwstppr Do we need any changes in the UI for this?

andrijapanicsb · 2024-05-28T10:05:38Z

@vishesh92 no - those are used later during importVm API to connect via ssh etc.

shwstppr · 2024-06-03T05:46:48Z

@blueorangutan package

blueorangutan · 2024-06-03T05:48:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-03T06:54:40Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9759

shwstppr · 2024-06-03T08:09:17Z

@blueorangutan test

blueorangutan · 2024-06-03T08:10:03Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-06-03T23:09:26Z

[SF] Trillian test result (tid-10328)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9124-t10328-kvm-centos7.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2024-06-11T13:03:07Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2024-06-12T08:09:12Z

@blueorangutan package

blueorangutan · 2024-06-12T08:10:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-12T09:37:16Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9888

vladimirpetrov

LGTM based on manual testing - the username parameter is no longer mandatory.

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2024-06-14T05:50:56Z

@blueorangutan package

blueorangutan · 2024-06-14T05:52:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

yadvr · 2024-06-14T06:45:20Z

Merged based on GHA smoketests and build tests.

blueorangutan · 2024-06-14T06:58:51Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9940

…he#9124) * server: remove username required condition for listVmsForImport Fixes apache#8414 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * revert Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr added 2 commits May 24, 2024 17:34

server: remove username required condition for listVmsForImport

10fc4a4

Fixes apache#8414 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

fix

c325034

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr requested a review from andrijapanicsb May 24, 2024 13:07

weizhouapache approved these changes May 24, 2024

View reviewed changes

weizhouapache added this to the 4.19.1.0 milestone May 24, 2024

DaanHoogland approved these changes May 28, 2024

View reviewed changes

vishesh92 approved these changes May 28, 2024

View reviewed changes

DaanHoogland mentioned this pull request May 28, 2024

import-vm: remove username, password request params for vm import apache/cloudstack-documentation#401

Merged

yadvr approved these changes Jun 2, 2024

View reviewed changes

DaanHoogland linked an issue Jun 4, 2024 that may be closed by this pull request

Minor: listVmsForImport API fix #8414

Closed

DaanHoogland added the status:needs-testing label Jun 4, 2024

github-actions bot added the status:has-conflicts label Jun 11, 2024

Merge branch '4.19' into fix-listvmforimport-usernameparam

24142e4

github-actions bot removed the status:has-conflicts label Jun 12, 2024

vladimirpetrov self-assigned this Jun 12, 2024

vladimirpetrov approved these changes Jun 13, 2024

View reviewed changes

vladimirpetrov removed the status:needs-testing label Jun 13, 2024

sureshanaparti reviewed Jun 13, 2024

View reviewed changes

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java Show resolved Hide resolved

revert

e2fb453

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr merged commit df5c546 into apache:4.19 Jun 14, 2024

yadvr deleted the fix-listvmforimport-usernameparam branch June 14, 2024 06:45

Conversation

shwstppr commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr commented May 24, 2024

Uh oh!

blueorangutan commented May 24, 2024

Uh oh!

blueorangutan commented May 24, 2024

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented May 28, 2024

Uh oh!

weizhouapache commented May 28, 2024

Uh oh!

vishesh92 commented May 28, 2024

Uh oh!

andrijapanicsb commented May 28, 2024

Uh oh!

shwstppr commented Jun 3, 2024

Uh oh!

blueorangutan commented Jun 3, 2024

Uh oh!

blueorangutan commented Jun 3, 2024

Uh oh!

shwstppr commented Jun 3, 2024

Uh oh!

blueorangutan commented Jun 3, 2024

Uh oh!

blueorangutan commented Jun 3, 2024

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

shwstppr commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

vladimirpetrov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Jun 14, 2024

Uh oh!

blueorangutan commented Jun 14, 2024

Uh oh!

yadvr commented Jun 14, 2024

Uh oh!

blueorangutan commented Jun 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

shwstppr commented May 24, 2024 •

edited

Loading

codecov bot commented May 24, 2024 •

edited

Loading